Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jordan/mobile #2777

Merged
merged 24 commits into from
Jun 27, 2019
Merged

Jordan/mobile #2777

merged 24 commits into from
Jun 27, 2019

Conversation

jbibla
Copy link
Collaborator

@jbibla jbibla commented Jun 25, 2019 •
edited
Loading

Closes #2766
Closes #2771

Description:

  • bunch of mobile improvements
  • scrolling and sizing fixes for mobile
  • still lots to improve 😅

Thank you! 🚀

For contributor:

  • Added changes entries. Run yarn changelog for a guided process.
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@jbibla jbibla requested review from colw and faboweb as code owners June 25, 2019 01:03
@jbibla
Copy link
Collaborator Author

jbibla commented Jun 25, 2019 •
edited
Loading

there is a failing test that has something to do with $emit - i just skipped it for now. would be curious to know if anyone knows what the deal is.

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 25, 2019

showing all values in balance header again
Screen Shot 2019-06-25 at 1 04 27 AM

mobile-friendly welcome screen
Screen Shot 2019-06-25 at 1 02 47 AM

big ol' button
Screen Shot 2019-06-25 at 1 01 24 AM

forms are spaced out a bit better
Screen Shot 2019-06-25 at 1 01 14 AM

@faboweb
Copy link
Collaborator

faboweb commented Jun 25, 2019

Pretty cool. The organization of the values in the header looks a bit chaotic imo. It also doesn't scale that well on medium sized screens:
image

@faboweb
Copy link
Collaborator

faboweb commented Jun 25, 2019

there is a failing test that has something to do with $emit - i just skipped it for now. would be curious to know if anyone knows what the deal is.

See my commits

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 25, 2019

thank you @faboweb - i tried that yesterday but put the brackets in the wrong place 🤦‍♂

@jbibla
Copy link
Collaborator Author

jbibla commented Jun 25, 2019

Pretty cool.

DANKE!

The organization of the values in the header looks a bit chaotic imo.

noted. i have an idea.

It also doesn't scale that well on medium sized screens:

yeah, i'll fix this.

@faboweb faboweb merged commit 26a9e93 into develop Jun 27, 2019
@faboweb faboweb deleted the jordan/mobile branch June 27, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colw colw Awaiting requested review from colw

@faboweb faboweb Awaiting requested review from faboweb faboweb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Delegate and Undelegate buttons spacing mobile fixes for session flow
2 participants
@jbibla @faboweb